languages/beancount: init #1100
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmvar
force-pushed
the
languages/beancount
branch
from
0d75b65 to
8259788
Compare
gmvar
requested review from
NotAShelf,
Soliprem and
horriblename
as code owners
gmvar
force-pushed
the
languages/beancount
branch
from
8259788 to
b38da6f
Compare
horriblename
requested changes
Sep 5, 2025
gmvar
force-pushed
the
languages/beancount
branch
from
b38da6f to
fa30514
Compare
horriblename
force-pushed
the
v0.8
branch
2 times, most recently
from
8b98f07 to
ba9ce8b
Compare
gmvar
force-pushed
the
languages/beancount
branch
from
fa30514 to
aade359
Compare
gmvar
force-pushed
the
languages/beancount
branch
from
aade359 to
25c8b76
Compare
gmvar
force-pushed
the
languages/beancount
branch
from
25c8b76 to
c6e58f0
Compare
NotAShelf
requested changes
Oct 30, 2025
Owner
NotAShelf
left a comment
NotAShelf
left a comment
There was a problem hiding this comment.
Sorry for the delay, I've meant to reply much earlier but kept forgetting each time. Two little comments before we can get this merged.
Comment on lines
50
to
55
| ::: {.note} | ||
| 'beancount-language-server' requires 'bean-check' and 'bean-format'. | ||
| Both are provided by 'pkgs.beancount'. These binaries must be in | ||
| your PATH or in 'vim.extraPackages'. There are no additional checks | ||
| to verify if this requirement is met. | ||
| ::: |
Owner
There was a problem hiding this comment.
Okay, this is what has been bothering me about this PR. Relying on packages being installed externally somehow is not something I'm very keen on. Ideally the beancount package should be wrapped here with the necessary dependencies in its path (via wrapProgram etc.) so that this warning is not necessary.
Author
There was a problem hiding this comment.
I'm not sure how to best use wrapProgram so I instead used writeShellScriptBin, the end result is the same and I tested everything works.
Please let me know what you think about this.
gmvar
force-pushed
the
languages/beancount
branch
from
c6e58f0 to
08caf4d
Compare
Create the `vim.languages.beancount` module using `bean-format` and `beancount-language-server`.
gmvar
force-pushed
the
languages/beancount
branch
from
08caf4d to
82b0452
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create the
vim.languages.beancountmodule usingbean-formatandbeancount-language-server.Current Issues
Formatting Behavior:
beancount-language-servercurrently lacks an option to disable formatting. This results in documents being automatically formatted, even when the settingvim.languages.beancount.format.enableis set tofalse.Formatting Package Installation:
vim.languages.beancount.format.enablesetting does not install the necessary formatting package, which isbean-format. This package is included inpkgs.beancount.beancount-language-serveralso depends onpkgs.beancount, leading to a decision point regarding installation options. I would appreciate guidance on the preferred approach:pkgs.beancounttovim.extraPackages: This would ensure that the formatting package is available without requiring additional user setup.bean-formatis available in their system PATH, similar to the current setup for the language server.Sanity Checking
nix fmt).#nix(default package).#maximal.#docs-html(manual, must build).#docs-linkcheck(optional, please build if adding links)x86_64-linuxaarch64-linuxx86_64-darwinaarch64-darwin